[livesupport-dev] case sensitive playlist element names
  • Vote Up0Vote Down importimport
    Posts: 0Member
    Hi developers, (mainly Sebastian and Ferenc)

    due to flaw in playlist related methods in GreenBox, element names in
    XML part of stored files were handled case insensitive.
    It's now changed to case sensitive to follow XML standard and
    playlist DTD (issue #832).

    Please, check if your parts depend on it.

    to Sebastian: I've fixed it already in htmlUi/var/ui_playlist.class.php
    (see cvs diff -r1.34 -r1.35 modules/htmlUi/var/ui_playlist.class.php)

    Tomas Hlava
    th@red2head.com

    ------------------------------------------
    Posted to Phorum via PhorumMail
  • 2 Comments sorted by
  • Vote Up0Vote Down importimport
    Posts: 0Member
    Dear Tomas,

    now I always use strtolower() in case of comparision element types, so it
    should be fine even if you need to change case of element names again, even
    "outside" of playlists.
    But maybee better to define some variables/constants in config file
    containing those strings?

    Sebastian



    > -----Ursprungliche Nachricht-----
    > Von: Tomas Hlava [mailto:th@red2head.com]
    > Gesendet: Mittwoch, 20. April 2005 00:37
    > An: livesupport-dev@campware.org
    > Betreff: [livesupport-dev] case sensitive playlist element names
    >
    >
    >
    > Hi developers, (mainly Sebastian and Ferenc)
    >
    > due to flaw in playlist related methods in GreenBox, element names in
    > XML part of stored files were handled case insensitive.
    > It's now changed to case sensitive to follow XML standard and
    > playlist DTD (issue #832).
    >
    > Please, check if your parts depend on it.
    >
    > to Sebastian: I've fixed it already in htmlUi/var/ui_playlist.class.php
    > (see cvs diff -r1.34 -r1.35 modules/htmlUi/var/ui_playlist.class.php)
    >
    > Tomas Hlava
    > th@red2head.com

    ------------------------------------------
    Posted to Phorum via PhorumMail
  • Vote Up0Vote Down importimport
    Posts: 0Member
    Sebastian Goebel wrote:
    > now I always use strtolower() in case of comparision element types, so it
    > should be fine even if you need to change case of element names again, even
    > "outside" of playlists.
    > But maybee better to define some variables/constants in config file
    > containing those strings?

    this is an excellent idea. using hard-coded magic values is generally a
    bad thing to do...

    ------------------------------------------
    Posted to Phorum via PhorumMail
Add a Comment