[campsite-dev] Comments on the "move template" code
  • Vote Up0Vote Down importimport
    Posts: 0Member
    Hi Holman -
    The new functionality is really good and I really liked the way you
    implemented it with the checkboxes and ability to move all the files at
    once. Here are some comments on the code:

    In list_dir.php:
    - Is it possible to make the "checkAll(), uncheckAll(), setPointer(),
    checkboxClick()" javascript functions more generic and put them into
    campsite.js? It looks like you got these from the Article List screen, so
    both of these scripts should be changed to use these generic functions. We
    should also probably put the first part of actionSelected() - the part the
    verifies that you have at least one checkbox selected - into a separate
    function that can be re-used. We should also document an example of how to
    use this set of functions.

    - There is some extra javascript in actionSelected(), such as leftover
    translate code. This should be removed.

    I found a couple bugs - they have been filed in Trac.

    - Paul
  • 2 Comments sorted by
  • Vote Up0Vote Down importimport
    Posts: 0Member
    Hi, Paul thanks for your comments. Most of the bugs have been already fixed.

    What do you think is the best way to manage those non-template files
    (e.g. images)?
    Do we need to implement the same move, rename, delete features on them
    as done for templates?



    On 8/27/06, Paul Baranowski wrote:
    > Hi Holman -
    > The new functionality is really good and I really liked the way you
    > implemented it with the checkboxes and ability to move all the files at
    > once. Here are some comments on the code:
    >
    > In list_dir.php:
    > - Is it possible to make the "checkAll(), uncheckAll(), setPointer(),
    > checkboxClick()" javascript functions more generic and put them into
    > campsite.js? It looks like you got these from the Article List screen, so
    > both of these scripts should be changed to use these generic functions. We
    > should also probably put the first part of actionSelected() - the part the
    > verifies that you have at least one checkbox selected - into a separate
    > function that can be re-used. We should also document an example of how to
    > use this set of functions.
    >
    > - There is some extra javascript in actionSelected(), such as leftover
    > translate code. This should be removed.
    >
    > I found a couple bugs - they have been filed in Trac.
    >
    > - Paul
    >
    >


    --
    /holman
  • Vote Up0Vote Down importimport
    Posts: 0Member
    On 8/27/06, Holman Romero wrote:
    >
    > Hi, Paul thanks for your comments. Most of the bugs have been already
    > fixed.
    >
    > What do you think is the best way to manage those non-template files
    > (e.g. images)?
    > Do we need to implement the same move, rename, delete features on them
    > as done for templates?


    Yes - the same operations should be possible with non-template files.
    (Those two questions above are the same question, right? Smile - otherwise ask
    me again)

    - Paul
Add a Comment